Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

knightos-z80e: init at 0.5.0 #99288

Merged
merged 1 commit into from Oct 17, 2020
Merged

knightos-z80e: init at 0.5.0 #99288

merged 1 commit into from Oct 17, 2020

Conversation

siraben
Copy link
Member

@siraben siraben commented Oct 1, 2020

Motivation for this change

knightos-z80e: init at 0.5.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siraben siraben mentioned this pull request Oct 14, 2020
Merged
10 tasks
@danieldk
Copy link
Contributor

BTW, feel free to ping me in the future if any KnightOS package PRs go stale.

@danieldk
Copy link
Contributor

Pushed a change that also puts knightos-scas in nativeBuildInputs plus some small formatting changes.

danieldk
danieldk approved these changes Oct 17, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 99288 1

1 package built:
  • knightos-z80e

@danieldk danieldk merged commit cd0e1c0 into NixOS:master Oct 17, 2020
@siraben siraben deleted the z80e-init branch October 17, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siraben @danieldk