Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obs-studio: 25.0.8 -> 26.0.0 #99242

Merged
merged 1 commit into from Oct 1, 2020
Merged

obs-studio: 25.0.8 -> 26.0.0 #99242

merged 1 commit into from Oct 1, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 1, 2020 •
edited

Motivation for this change

saw it was released

able to launch it, and it seems to be working fine :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/99242
1 package failed to build:
obs-ndi

4 packages built:
obs-linuxbrowser obs-studio obs-v4l2sink obs-wlrobs

@ofborg ofborg bot requested review from jb55 and MP2E October 1, 2020 09:22
@mweinelt
Copy link
Member

mweinelt commented Oct 1, 2020

Builds, runs and streams. LGTM!

Result of nixpkgs-review pr 99242 1

1 package marked as broken and skipped:
  • obs-ndi
4 packages built:
  • obs-linuxbrowser
  • obs-studio
  • obs-v4l2sink
  • obs-wlrobs

@mweinelt mweinelt merged commit 730751e into NixOS:master Oct 1, 2020
@Munksgaard Munksgaard mentioned this pull request Oct 1, 2020
Merged
10 tasks
@jonringer jonringer deleted the bump-obs branch October 1, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@elohmeier elohmeier Awaiting requested review from elohmeier

@jb55 jb55 Awaiting requested review from jb55

@MP2E MP2E Awaiting requested review from MP2E

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @mweinelt