New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TabNine cli and completion-tabnine vim plugin #99264
Conversation
b7b7461
to
a82354e
Compare
3dedee9
to
4f43303
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing update commit
When adding new vim plugins, please follow directions for adding new vim plugins.
The steps should roughly be:
git checkout -b <branch-name>
GITHUB_API_TOKEN=[personal token] ./pkgs/misc/vim-plugins/update.py --add "[owner]/[name]"
git push <fork> <branch>
you should see the following in your commit history:
vimPlugins: update
vimPlugins.[name]: init at <date>
If the package needs additional patching or you want to include a meta section, please put the related changes in pkgs/misc/vim-plugins/overrides.nix
. Do not edit the generated.nix, as those changes will be lost next update.
Why GITHUB_API_TOKEN?
Github limits github queries to 100/hr if you're a guest, but if you have a personal token, it will raise it to 5000/hr. The vim plugin update script will query the repositories to see what the latest release was, which will exceed the unauthenticated query limit.
For documentation on creating a token, please refer to the official docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mind updating vim-clap
's cargoSha, looks like they updated the lockfile
https://github.com/NixOS/nixpkgs/pull/99264
2 packages marked as broken and skipped:
tabnine vimPlugins.completion-tabnine
1 package failed to build:
vimPlugins.vim-clap
41 packages built:
vimPlugins.Coqtail vimPlugins.Supertab vimPlugins.Syntastic vimPlugins.Tagbar vimPlugins.YouCompleteMe vimPlugins.ale vimPlugins.coc-explorer vimPlugins.coc-markdownlint vimPlugins.completion-nvim vimPlugins.diagnostic-nvim vimPlugins.direnv-vim vimPlugins.easymotion vimPlugins.fugitive vimPlugins.lh-brackets vimPlugins.lh-vim-lib vimPlugins.neoformat vimPlugins.neoterm vimPlugins.nvim-gdb vimPlugins.nvim-treesitter vimPlugins.polyglot vimPlugins.tmuxNavigator vimPlugins.vim-abolish vimPlugins.vim-autoformat vimPlugins.vim-cue vimPlugins.vim-elixir vimPlugins.vim-go vimPlugins.vim-gutentags vimPlugins.vim-javascript-syntax vimPlugins.vim-jsx-pretty vimPlugins.vim-lsc vimPlugins.vim-lsp vimPlugins.vim-monokai vimPlugins.vim-rails vimPlugins.vim-snippets vimPlugins.vim-test vimPlugins.vim-visual-multi vimPlugins.vim-which-key vimPlugins.vimspector vimPlugins.vimtex vimPlugins.vista-vim vimPlugins.yats-vim
sure, will do it in a few minutes. |
I'm running
it's also one of the bullets on the template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 99264 1
2 packages marked as broken and skipped:
- tabnine
- vimPlugins.completion-tabnine
1 package failed to build:
- vimPlugins.vim-clap
41 packages built:
- vimPlugins.Coqtail
- vimPlugins.Supertab (vimPlugins.supertab)
- vimPlugins.Syntastic (vimPlugins.syntastic)
- vimPlugins.Tagbar (vimPlugins.tagbar)
- vimPlugins.YouCompleteMe
- vimPlugins.ale
- vimPlugins.coc-explorer
- vimPlugins.coc-markdownlint
- vimPlugins.completion-nvim
- vimPlugins.diagnostic-nvim
- vimPlugins.direnv-vim
- vimPlugins.easymotion (vimPlugins.vim-easymotion)
- vimPlugins.fugitive (vimPlugins.vim-fugitive)
- vimPlugins.lh-brackets
- vimPlugins.lh-vim-lib
- vimPlugins.neoformat
- vimPlugins.neoterm
- vimPlugins.nvim-gdb
- vimPlugins.nvim-treesitter
- vimPlugins.polyglot (vimPlugins.vim-polyglot)
- vimPlugins.tmuxNavigator (vimPlugins.tmux-navigator ,vimPlugins.vim-tmux-navigator)
- vimPlugins.vim-abolish
- vimPlugins.vim-autoformat
- vimPlugins.vim-cue
- vimPlugins.vim-elixir
- vimPlugins.vim-go
- vimPlugins.vim-gutentags
- vimPlugins.vim-javascript-syntax
- vimPlugins.vim-jsx-pretty
- vimPlugins.vim-lsc
- vimPlugins.vim-lsp
- vimPlugins.vim-monokai
- vimPlugins.vim-rails
- vimPlugins.vim-snippets
- vimPlugins.vim-test
- vimPlugins.vim-visual-multi
- vimPlugins.vim-which-key
- vimPlugins.vimspector
- vimPlugins.vimtex
- vimPlugins.vista-vim
- vimPlugins.yats-vim
I should have built the unfree packages:
|
I'll make a new PR to fix this |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)