Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.dune-configurator: add minimumOCamlVersion #99265

Merged
merged 1 commit into from Oct 1, 2020
Merged

ocamlPackages.dune-configurator: add minimumOCamlVersion #99265

merged 1 commit into from Oct 1, 2020

Conversation

hongchangwu
Copy link
Contributor

Motivation for this change

Source: https://github.com/ocaml/opam-repository/blob/master/packages/dune-configurator/dune-configurator.2.7.1/opam#L21

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions: Ubuntu
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hongchangwu
Copy link
Contributor Author

hongchangwu commented Oct 1, 2020 •
edited

@GrahamcOfBorg build ocaml-ng.ocamlPackages_4_03.dune-configurator ocaml-ng.ocamlPackages_4_08.dune-configurator

@hongchangwu hongchangwu mentioned this pull request Oct 1, 2020
Merged
10 tasks
@vbgl vbgl merged commit d1ad520 into NixOS:master Oct 1, 2020
@hongchangwu hongchangwu deleted the dune-configurator branch October 1, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hongchangwu @vbgl