Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme-jade1: 1.8 -> 1.9 #99300

Merged
merged 1 commit into from Oct 5, 2020
Merged

theme-jade1: 1.8 -> 1.9 #99300

merged 1 commit into from Oct 5, 2020

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Oct 1, 2020

Motivation for this change
  • Update to version 1.9
  • Include all the color variants
  • Use .tar.xz upstream source, as it includes all color variants, otherwise available only as git branches
  • Run preInstall and postInstall hooks
  • Change license to gpl3only
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo
theme-jade1: 1.8 -> 1.9
142da72 
- Update to version 1.9
- Include all the color variants
- Use .tar.xz upstream source, as it includes all color variants,
  otherwise available only as git branches
- Run preInstall and postInstall hooks
- Change license to gpl3only
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/320

@romildo
Copy link
Contributor Author

romildo commented Oct 5, 2020

As it is a simple package update, tested locally, I am going to merge.

@romildo romildo merged commit d1bf7db into NixOS:master Oct 5, 2020
@romildo romildo deleted the upd.theme-jade1 branch October 5, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @nixos-discourse