Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/httpd: remove unnecessary sendmail configuration #99251

Merged
merged 2 commits into from Oct 5, 2020
Merged

nixos/httpd: remove unnecessary sendmail configuration #99251

merged 2 commits into from Oct 5, 2020

Conversation

KamilaBorowska
Copy link
Member

@KamilaBorowska KamilaBorowska commented Oct 1, 2020 •
edited

PHP now uses system-sendmail without special configuration (see #95898).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KamilaBorowska
nixos/httpd: remove unnecessary sendmail configuration
05eb349 
PHP now uses system-sendmail without special configuration.
@aanderse
Copy link
Member

aanderse commented Oct 1, 2020

Looks like

nixpkgs/nixos/modules/services/web-servers/phpfpm/default.nix

Line 30 in 730751e

sendmail_path = "/run/wrappers/bin/sendmail -t -i"
can be cleaned up a bit too. @xfix - are you interested in tackling that?

@aanderse
Copy link
Member

aanderse commented Oct 3, 2020

ping @NixOS/php

@aanderse
Copy link
Member

aanderse commented Oct 3, 2020

@GrahamcOfBorg test php.fpm php.httpd

@aanderse aanderse merged commit dedd676 into NixOS:master Oct 5, 2020
@aanderse
Copy link
Member

aanderse commented Oct 5, 2020

Thanks @xfix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu etu approved these changes

@aanderse aanderse Awaiting requested review from aanderse

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KamilaBorowska @aanderse @etu