Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyscreenshot: add missing pillow dependency #99292

Merged
merged 1 commit into from Oct 1, 2020
Merged

pythonPackages.pyscreenshot: add missing pillow dependency #99292

merged 1 commit into from Oct 1, 2020

Conversation

lsix
Copy link
Member

@lsix lsix commented Oct 1, 2020

Motivation for this change

Issue spotted by @mweinelt in #99244 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

mweinelt commented Oct 1, 2020

Result of nixpkgs-review pr 99292 1

3 packages built:
  • python27Packages.pyscreenshot
  • python37Packages.pyscreenshot
  • python38Packages.pyscreenshot

@mweinelt mweinelt merged commit d83af32 into NixOS:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lsix @mweinelt