Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ifcopenshell: init at 0.6.0b #99246

Merged
merged 2 commits into from Nov 28, 2020
Merged

pythonPackages.ifcopenshell: init at 0.6.0b #99246

merged 2 commits into from Nov 28, 2020

Conversation

fehnomenal
Copy link
Contributor

@fehnomenal fehnomenal commented Oct 1, 2020 •
edited

Motivation for this change

ifcopenshell is missing.

Fixes #72468

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fehnomenal
Copy link
Contributor Author

FYI: I'm using this package since the creation of this PR with no problems together with FreeCAD and I'd love to get this merged.
Are there any blockers (besides a huge pile of PRs)?

SuperSandro2000
SuperSandro2000 reviewed Nov 26, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides a huge pile of PRs

Nope.

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/development/python-modules/ifcopenshell/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 99246 run on x86_64-linux 1

3 packages built:
  • python27Packages.ifcopenshell
  • python37Packages.ifcopenshell
  • python38Packages.ifcopenshell

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 99246 run on x86_64-darwin 1

3 packages failed to build:
  • python27Packages.ifcopenshell
  • python37Packages.ifcopenshell
  • python38Packages.ifcopenshell

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 99246 run on x86_64-darwin 1

3 packages built:
  • python27Packages.ifcopenshell
  • python37Packages.ifcopenshell
  • python38Packages.ifcopenshell

@SuperSandro2000 SuperSandro2000 merged commit 069f11d into NixOS:master Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Packaging requests: IfcOpenShell (python module)
3 participants
@fehnomenal @SuperSandro2000 @Janik-Haag