Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btrbk: 0.29.1 -> 0.31.3 #99303

Merged
merged 1 commit into from Oct 18, 2021
Merged

btrbk: 0.29.1 -> 0.31.3 #99303

merged 1 commit into from Oct 18, 2021

Conversation

woffs
Copy link
Contributor

@woffs woffs commented Oct 1, 2020 •
edited

Motivation for this change
  • new: lsbtr
  • work around non-working --argv0 when wrapping perl or shell scripts
  • add updateScript
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from asymmetric October 1, 2020 20:45
asymmetric
asymmetric reviewed Oct 3, 2020
View reviewed changes
Copy link
Contributor

@asymmetric asymmetric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pkgs/tools/backup/btrbk/default.nix Show resolved Hide resolved
@ofborg ofborg bot requested a review from asymmetric October 31, 2020 12:41
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 99303 run on x86_64-linux 1

1 package built:
  • btrbk

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 99303 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • btrbk

@SuperSandro2000
Copy link
Member

@woffs Can you solve the merge conflict?

@woffs
Copy link
Contributor Author

woffs commented Nov 26, 2020

@woffs Can you solve the merge conflict?

done.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 99303 run on x86_64-linux 1

1 package built:
  • btrbk

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

@asymmetric
Copy link
Contributor

asymmetric commented Dec 28, 2020 •
edited

It's gpl3Only.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 99303 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • btrbk

SuperSandro2000
SuperSandro2000 requested changes Jan 18, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the merge conflict.

pkgs/tools/backup/btrbk/default.nix Outdated Show resolved Hide resolved
@woffs woffs force-pushed the btrbk-0.30.0 branch 2 times, most recently from 889578f to 333e87e Compare January 21, 2021 00:06
asymmetric
asymmetric reviewed Jan 21, 2021
View reviewed changes
Copy link
Contributor

@asymmetric asymmetric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.31.0 was released

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 99303 run on x86_64-linux 1

1 package built:
  • btrbk

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

btrbk:

Please consider this feature to be alpha.

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern '/etc' doesn't match anything in file './doc/Makefile'
substituteStream(): WARNING: pattern '/bin/date' doesn't match anything in file 'contrib/cron/btrbk-mail'
substituteStream(): WARNING: pattern '/bin/echo' doesn't match anything in file 'contrib/cron/btrbk-mail'

Please check the offending substituteInPlace for typos or changes in source.

@woffs woffs changed the title btrbk: 0.29.1 -> 0.30.0 btrbk: 0.29.1 -> 0.31.0 Jan 21, 2021
@ofborg ofborg bot requested a review from asymmetric January 21, 2021 20:07
@woffs woffs changed the title btrbk: 0.29.1 -> 0.31.0 btrbk: 0.29.1 -> 0.31.1 Mar 19, 2021
@stale
Copy link

stale bot commented Sep 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 19, 2021
@woffs
btrbk: 0.29.1 -> 0.31.3
f28de9c 
- add updateScript
- work around non-working --argv0 when wrapping perl or shell scripts
- change license to gpl3Only
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 21, 2021
@woffs woffs changed the title btrbk: 0.29.1 -> 0.31.1 btrbk: 0.29.1 -> 0.31.3 Sep 21, 2021
@SuperSandro2000 SuperSandro2000 merged commit f3df5ef into NixOS:master Oct 18, 2021
@asymmetric asymmetric mentioned this pull request Oct 18, 2021
Closed
12 tasks
@FliegendeWurst FliegendeWurst mentioned this pull request Jan 28, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asymmetric asymmetric Awaiting requested review from asymmetric

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@woffs @SuperSandro2000 @asymmetric @FliegendeWurst