Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfsUnstable: 2.0.0-rc1 -> 2.0.0-rc2 #99271

Merged
merged 1 commit into from Oct 2, 2020
Merged

Conversation

clefru
Copy link
Contributor

@clefru clefru commented Oct 1, 2020

(cherry picked from commit a115901)

Motivation for this change

cherry-picking zfsUnstable from master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

(cherry picked from commit a115901)
@clefru
Copy link
Contributor Author

clefru commented Oct 1, 2020

@GrahamcOfBorg test zfs.unstable

@jonringer @hmenke: I'd like to also bump zfsUnstable from 2.0.0-rc1 to 2.0.0-rc2 in release-20.09. Thanks :)

@jonringer
Copy link
Contributor

It does contain bugfixes... not sure how i feel about unstable versions on a stable release channel....

either way I think it's beneficial to have rc2 over rc1 available

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 99271 1

2 packages marked as broken and skipped:
  • linuxPackages_hardkernel_4_14.zfsUnstable
  • linuxPackages_hardkernel_latest.zfsUnstable
18 packages built:
  • linuxPackages-libre.zfsUnstable
  • linuxPackages.zfsUnstable (linuxPackages_5_4.zfsUnstable)
  • linuxPackages_4_14.zfsUnstable
  • linuxPackages_4_19.zfsUnstable
  • linuxPackages_4_4.zfsUnstable
  • linuxPackages_4_9.zfsUnstable
  • linuxPackages_5_7.zfsUnstable
  • linuxPackages_5_8.zfsUnstable (linuxPackages_latest.zfsUnstable)
  • linuxPackages_hardened.zfsUnstable
  • linuxPackages_latest-libre.zfsUnstable
  • linuxPackages_latest_hardened.zfsUnstable
  • linuxPackages_latest_xen_dom0.zfsUnstable
  • linuxPackages_latest_xen_dom0_hardened.zfsUnstable
  • linuxPackages_testing_bcachefs.zfsUnstable
  • linuxPackages_xen_dom0.zfsUnstable
  • linuxPackages_xen_dom0_hardened.zfsUnstable
  • linuxPackages_zen.zfsUnstable
  • zfsUnstable

@jonringer jonringer merged commit c40a706 into NixOS:release-20.09 Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants