Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.sslyze: Update dependencies #98121

Closed
wants to merge 1 commit into from
Closed

python3Packages.sslyze: Update dependencies #98121

wants to merge 1 commit into from

Conversation

Pamplemousse
Copy link
Member

@Pamplemousse Pamplemousse commented Sep 16, 2020 •
edited

Motivation for this change

It does not seem to support cryptography >= 3:
nabla-c0d3/sslyze#455

Depends on #98118 . (there should not be multiple versions of cryptography in nixpkgs)

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Sep 16, 2020

Python 3 libraries in Nixpkgs cannot use another cryptography version.

FRidh
FRidh requested changes Sep 16, 2020
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is still not possible. Libraries simply cannot use a different version of another library, because that can lead to conflicts.
Upstream needs to fix support. Until then it is simply broken in Nixpkgs.

@Pamplemousse
python3Packages.sslyze: Update dependencies
b036cd5 
It does not seem to support cryptography >= 3:
  nabla-c0d3/sslyze#455

  * remove unecessary patch
  * mark as broken

Signed-off-by: Pamplemousse <xav.maso@gmail.com>
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/why-shouldnt-there-be-different-version-of-libraries-in-nixpkgs/9029/1

@jonringer
Copy link
Contributor

conflicts

@Pamplemousse
Copy link
Member Author

Superseded by #98301 .

@Pamplemousse Pamplemousse deleted the sslyze branch September 23, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Pamplemousse @FRidh @nixos-discourse @jonringer