Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] fzf: 0.20 -> 0.22 #98132

Merged
merged 4 commits into from Sep 20, 2020
Merged

[20.03] fzf: 0.20 -> 0.22 #98132

merged 4 commits into from Sep 20, 2020

Conversation

roosemberth
Copy link
Contributor

@roosemberth roosemberth commented Sep 16, 2020 •
edited

Motivation for this change

NixOS 20.09 is not released yet, and some tools I use myself require a newer version of fzf. The impact should be minimal.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

This isn't an actual backport like https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes documents. Can you please fix this?

@roosemberth
Copy link
Contributor Author

This isn't an actual backport like https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes documents. Can you please fix this?

There are 8 commits (which I guess would be fine if they only referenced this file). However among them there is d6162da which hasn't been backported and touches tons of files. I thought that squashing all those commits and scoping the changes would be acceptable.

@zowoq
Copy link
Contributor

zowoq commented Sep 17, 2020

There are 8 commits

Not every commit needs to be backported, in this case a couple of them shouldn't be backported.

@zowoq zowoq merged commit 21d8e70 into NixOS:release-20.03 Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

@zowoq zowoq Awaiting requested review from zowoq

@kalbasit kalbasit Awaiting requested review from kalbasit

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roosemberth @worldofpeace @zowoq