-
Notifications
You must be signed in to change notification settings - Fork 512
Export canvas x / y offset is inverted #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@Symbian9 is this right? It seems like the offset should be relative to the canvas origin. If you export with no offset it would place things at the edge of the canvas, so you'd want to use a positive offset within that coordinate system. At least that's my interpretation which could be wrong. Same thing when 3d printing, I have to tell the slicer where my print-bed corner is relative to the home position of the printer - which would look a lot like this and requires positive offset values. |
Yes. @phkahler, on my screenshot above lower left corner of rectangle ("visible entity") placed at the canvas origin (by "Center View At Point"). But if set "export canvas size: So, actually exported "visible entities" moved according offset values instead of expected moving "export canvas" window. SOLUTION: Switch internal calculated positive values of "offset |
So here is a picture. I created a 50x40 rectangle with the lower point at the origin. I exported as svg and opened that at the top. It's hard to see the purple because there is no background. The X and Y offsets work exactly as I expect. The rectangle is 20 from the left of the SVG origin and 5 from the bottom - as specified in the export offset values. I also confirmed that 0 aligns with the left side for X offset and bottom for Y. I honestly don't see any problem here. I also tried exporting G-code, but it didn't seem to be affected by these settings - the point coordinates were 0, 40 , and 50. I have not tried any other export options. As far as I can tell these settings are not visible in any way on the SolveSpace sketch and I would not expect them to be. @Symbian9 Can you be give a better example of the problem? Perhaps a simple .slvs and an exported file that behaves incorrectly? |
But for "export canvas size: This is NOT "paper margins" (as it defined for "export canvas size: FTR, If actual "export canvas size: OR add option to select how calculate its origin via radio buttons:
|
No, I mean working space canvas origin (as defined in "Center View At Point" option). |
@Symbian9 Can you verify this change does what you want for this issue? It's just the last commit: phkahler@d94cfad |
System information
3.0~690f87c
Expected behavior
Export canvas x / y offset should be relative to left-bottom x / y position.
Actual behavior
Export canvas x / y offset actually is inverted (really it should be -x / -y, as actually positive increasing offsets move export canvas origin to down-left direction)
Additional information
For bugs, please attach a savefile that shows the problematic behavior.
You can attach
.slvs
files by archiving them into a.zip
first.The text was updated successfully, but these errors were encountered: