Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ntfy: Switch to python3. Also fixes test failure #98140

Merged
merged 1 commit into from Sep 17, 2020
Merged

ntfy: Switch to python3. Also fixes test failure #98140

merged 1 commit into from Sep 17, 2020

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Sep 17, 2020 •
edited

Motivation for this change

Fixes test error (https://hydra.nixos.org/build/126783668):

AttributeError: 'module' object has no attribute 'test_prowl'
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Should be backported to 20.09 for #97479 after merging.

@nh2
ntfy: Switch to python3. Also fixes test failure.
3559369 
Fixes test error:

    AttributeError: 'module' object has no attribute 'test_prowl'
@nh2 nh2 self-assigned this Sep 17, 2020
@nh2 nh2 merged commit 3c6ed1a into NixOS:master Sep 17, 2020
@nh2 nh2 mentioned this pull request Sep 17, 2020
Merged
10 tasks
@nh2
Copy link
Contributor Author

nh2 commented Sep 17, 2020

20.09 backport at #98160.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilchm kamilchm kamilchm approved these changes

@jfrankenau jfrankenau Awaiting requested review from jfrankenau

Assignees

@nh2 nh2

Labels
0.kind: enhancement 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nh2 @kamilchm