Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signal-desktop: ringrtc depends on libpulseaudio #98135

Merged
merged 1 commit into from Sep 17, 2020
Merged

signal-desktop: ringrtc depends on libpulseaudio #98135

merged 1 commit into from Sep 17, 2020

Conversation

collares
Copy link
Member

voice/video calls should now work, fixing #98082

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@collares
signal-desktop: ringrtc depends on libpulseaudio
911a94f 
voice/video calls should now work, fixing NixOS#98082
primeos
primeos approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The diff LGTM :)

@primeos primeos merged commit 3df04be into NixOS:master Sep 17, 2020
@primeos primeos mentioned this pull request Sep 17, 2020
Closed
@collares collares deleted the signal-desktop branch September 22, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixmatus ixmatus ixmatus approved these changes

@primeos primeos primeos approved these changes

@equirosa equirosa Awaiting requested review from equirosa

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@collares @ixmatus @primeos