openmvs: bump version to latest release and fix build #98134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
ajs124
reviewed
Dec 29, 2020
| @@ -57,8 +56,7 @@ stdenv.mkDerivation { | |||
| homepage = "http://cdcseacave.github.io/openMVS/"; | |||
| license = licenses.agpl3; | |||
| platforms = platforms.linux; | |||
| maintainers = with maintainers; [ mdaiter ]; | |||
| maintainers = with maintainers; [ mdaiter timput ]; | |||
| # 20190414-174115: CMake cannot find CGAL which is passed as build input | |||
There was a problem hiding this comment.
Is the comment still relevant if this is not broken anymore?
Also, I can verify that this builds (which I did), but I don't really know what this does, so I can't really test it.
Seeing as you're adding yourself as maintainer, I'd trust you that this actually does what it's supposed to.
There was a problem hiding this comment.
You are correct about that comment, I've removed it now.
I've also changed the commit message to better align with CONTRIBUTING.md
TimPut
force-pushed
the
openmvsbumpnfix
branch
from
d62955e
to
48b2aab
Compare
TimPut
force-pushed
the
openmvsbumpnfix
branch
from
48b2aab
to
8327715
Compare
|
@ofborg eval |
|
Please fix evaluation |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closed by #211780. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
openmvs-unstable was based on an old version of openmvs and has been broken for a long time.
Things done
This commit bumps openmvs to a stable release, bumps the CGAL dependency to a needed newer version and fixes the build.
cdcseacave/openMVS#364 (comment)
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)