[Gecko Bug 1518999] Update ContentfulPaint algorithm to follow the spec #25578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 16, 2020
|
@sefeng211 This seems to be intermittent in Chrome. Is that expected and/or can we fix the test to not be intermittent? |
|
@jgraham Thanks, this is not expected and I'll need to take a look. Since the corresponding Gecko patches have backed out, shouldn't this PR get closed? I'll probably need to fix the test and then reland the Gecko part. Is it okay if we leave it open? |
moz-wptsync-bot
force-pushed
the
gecko/1518999-1
branch
from
d37a215
to
39f91bf
Compare
This patch includes a couple of changes. 1) Notify contentful paint only during refresh driver ticks. 2) Not only the root document, sub document should also have their own contentful paint entry. 3) Consider invisible text as contentful as well. Differential Revision: https://phabricator.services.mozilla.com/D89498 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1518999 gecko-commit: 47629f89cb6a8a8a663789855591a3d17466493b gecko-reviewers: emilio
moz-wptsync-bot
force-pushed
the
gecko/1518999-1
branch
from
39f91bf
to
937263a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch includes a couple of changes.
contentful paint entry.
Differential Revision: https://phabricator.services.mozilla.com/D89498
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1518999
gecko-commit: 5a6cea5fd344070dd197d368bfa4f92dfb31313e
gecko-reviewers: emilio