Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atom, atom-beta: fix not working file deletion #98124

Merged
merged 1 commit into from Jan 23, 2021

Conversation

Gerschtli
Copy link
Contributor

Motivation for this change

Through deprecation of gvfs-trash, gio has to be in PATH. Atom
automagically detects gio and uses it.

Fixes #97233

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Sep 30, 2020

I still see the failure popup even with this.

@Gerschtli
Copy link
Contributor Author

@teto Sorry but I can't reproduce this issue anymore with my fix.. Can you provide more information on how you build and run atom?

@SuperSandro2000
Copy link
Member

@Gerschtli please resolve the merge conflict.

Through deprecation of gvfs-trash, gio has to be in PATH. Atom
automagically detects gio and uses it.
@Gerschtli
Copy link
Contributor Author

@SuperSandro2000 Done :)

@SuperSandro2000 SuperSandro2000 merged commit 1af6e3a into NixOS:master Jan 23, 2021
@Gerschtli Gerschtli deleted the fix/atom branch November 28, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atom can not delete files
4 participants