sameboy: init at 0.13.6 #98177
Merged
sameboy: init at 0.13.6 #98177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested it using |
IvarWithoutBones
requested changes
Sep 18, 2020
| installPhase = '' | ||
| pushd build/bin/SDL | ||
| install -Dm755 sameboy $out/bin/sameboy | ||
| rm sameboy |
There was a problem hiding this comment.
There's no need to remove this manually, the build env gets garbage collected in its entirety when it's not required anymore.
There was a problem hiding this comment.
That's not the role of this rm. The goal here is to avoid * matching the binary itself, copying only the rest. Should I add a comment to this effect? Or maybe there's a more idiomatic way of achieving this?
meithecatte
force-pushed
the
sameboy
branch
from
250bc84
to
2700090
Compare
ehmry
approved these changes
Sep 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds a new package.
Things done
sandboxinnix.confon non-NixOS linux)./result/bin/)nix path-info -Sbefore and after)