Re-do "improve links" #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a66b8e1.
|
:/ this wasn't ready to merge, since there were the bugs to fix still. I'll do that on the main PR I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't trying to be flippant in a66b8e1, it causes misc. issues around the site as this adds borders to links wholesale.
Some links are "structural" in the site; they are
display: blockto fill their parent element to make a bigger touchable target.The best example of an issue this change causes is in the tabs navigation:
This is not the only issue this causes, but this is the most obvious.
What is the desired outcome of replacing the font-engine-native underline with a border? I don't see how this is improved.
The font-engine-native underline does things a border cannot do, like not striking through descenders.
While a border can do things the font-engine-native underline cannot do, but here it's not being done. Things like using a dotted or dashed underline, or changing the colour or size independently.
In a discussion with @garbas, I learned the reasoning behind this change.
It seems that user-experience research at mozilla found out that font-engine-native underlines make things hard to read, compared to the more spaced-out lines the borders allow.
I am personally somewhat doubting this until I can see research, but still can see how it can be a statistically-proven truth.
Thus, we probably can do this, but there are issues this causes. The main problem this causes is that at any place in the site a link is used as structural element, it needs to also gain the proper rules to prevent its border to be used. It also causes issues in that a "structural" element link can't gain a "proper" underline.
This sounds like something that shouldn't be pushed down onto the web developers to fix, but it's probably a much more complicated issue because of the incredible amount of baggage web design work is built on.