[mathml] Only perform special handling of <mo>s when they are text-only #25590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 17, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2414282
branch
2 times, most recently
from
885f2e9
to
9c0820e
Compare
MathML Core says special properties of operators happen when the corresponding <mo> elements contain text content only [1]. However, Blink currently just reads the element's textContent() without checking whether it contains non-text children. This CL fixes that behavior and also adds a WPT test to verify correct lspace/rspace (including after dynamic change of the <mo> content). [1] https://mathml-refresh.github.io/mathml-core/#dfn-algorithm-for-determining-the-properties-of-an-embellished-operator Bug: 6606 Change-Id: Iab0e3309bf03167889e4a7161fd053a4a9744908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414282 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#808089}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2414282
branch
from
9c0820e
to
53723cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MathML Core says special properties of operators happen when the
corresponding <mo> elements contain text content only [1]. However,
Blink currently just reads the element's textContent() without checking
whether it contains non-text children. This CL fixes that behavior and
also adds a WPT test to verify correct lspace/rspace (including after
dynamic change of the <mo> content).
[1] https://mathml-refresh.github.io/mathml-core/#dfn-algorithm-for-determining-the-properties-of-an-embellished-operator
Bug: 6606
Change-Id: Iab0e3309bf03167889e4a7161fd053a4a9744908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414282
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Reviewed-by: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#808089}