Add support for other registries and bump dependencies #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mainly resolves a CVE warning in node-fetch.
TrueBrain
force-pushed
the
more_registries
branch
5 times, most recently
from
debb053
to
f85084d
Compare
This allows migration to the GitHub Container Registry (ghcr.io).
TrueBrain
force-pushed
the
more_registries
branch
from
f85084d
to
2a778b5
Compare
frosch123
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be
v2, as it breaks compatibility withv1.Docker Hub
See the next two URLs for proof it still works (this was a run with unmodified GitHub workflows):
https://github.com/TrueBrain/test-actions/actions/runs/257943006
https://github.com/TrueBrain/test-actions/actions/runs/257950716
With the resulting image here:
docker pull truebrain/test-actions:developmentdocker pull docker.io/truebrain/test-actions:development(yes, the last one (deliberately) fails, and by then all the actions are triggered at least once)
GitHub Container Registry (GHCR)
And to proof a different registry works (this was a run with modified GitHub workflows):
https://github.com/TrueBrain/test-actions/actions/runs/257965556
With the resulting image here:
docker pull ghcr.io/truebrain/test-actions:development