Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sc-controller: fix missing icons (librsvg) #98116

Merged
merged 1 commit into from Sep 21, 2020
Merged

sc-controller: fix missing icons (librsvg) #98116

merged 1 commit into from Sep 21, 2020

Conversation

timjrd
Copy link
Contributor

@timjrd timjrd commented Sep 16, 2020

Motivation for this change

Fix missing SVG icons apparently due to redundant declaration/loading of librsvg.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timjrd
Copy link
Contributor Author

timjrd commented Sep 16, 2020

Maybe I should ping @orivej and @rnhmjoj for review.

@ofborg ofborg bot requested a review from rnhmjoj September 16, 2020 17:49
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Sep 16, 2020

Uhm, I didn't write that line (@orivej did) so I'm not sure on why it's needed. Removing it may have some unintended side effect...

orivej
orivej approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@orivej orivej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not investigated this, but your change looks OK since 0c2ede9#diff-036410e9211b4336186fc613f7200b12

@rnhmjoj rnhmjoj merged commit 799f149 into NixOS:master Sep 21, 2020
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Oct 9, 2020

Today I switched to 20.09: I noticed the problem but this commit is not fixing it. Also, It's more serious than just aesthetics: various menus are not working because the code loading the icons is throwing exceptions.

I think the application is not wrapped correctly.
@timjrd Is it working for you, now? If it is, it means the program is picking up whatever resources or library it needs from your environment as an impurity.

@timjrd
Copy link
Contributor Author

timjrd commented Oct 9, 2020

@rnhmjoj No it's not working anymore. But at the time I did the patch it was working: I tested the exact same build with and without this line and it fixed the issue. Sorry to have submitted a wrong patch :(.

At the same time I also wrapped sc-controller's AppImage (which was not trivial), and it's still working fine. Here is the package if it can help:
sc-controller-bin.tar.gz

@timjrd
Copy link
Contributor Author

timjrd commented Oct 9, 2020

Specifically I had to patch AppRun to remove some gdk-pixbuf related stuff.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Oct 10, 2020 •
edited

I run a bisect and it seems the bad commit was
6c5983a.
EDIT:
Confirmed by reverting and rebuilding sc-controller. I'm not sure why that whould break svg support, though.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Oct 10, 2020

ping @matthewbauer

@rnhmjoj rnhmjoj mentioned this pull request Oct 11, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

@rnhmjoj rnhmjoj Awaiting requested review from rnhmjoj

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timjrd @rnhmjoj @orivej