Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] wordgrinder: fix build #98170

Merged
merged 1 commit into from Sep 19, 2020
Merged

[20.09] wordgrinder: fix build #98170

merged 1 commit into from Sep 19, 2020

Conversation

liff
Copy link
Contributor

@liff liff commented Sep 17, 2020 •
edited

Motivation for this change

Backport of #97911

ZHF: #97479

cc @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

Please follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes and use git cherry-pick -x.

@risicle
Copy link
Contributor

risicle commented Sep 17, 2020 •
edited

☝️ Yup, basically needs chrerry-pick info in commit message.

Other than that, WFM macos 10.14, linux x86_64.

@liff
wordgrinder: fix build
182c9af 
(cherry picked from commit 8cb1e75)
@liff
Copy link
Contributor Author

liff commented Sep 19, 2020

Oops, sorry about that. Should be fixed now.

@worldofpeace worldofpeace merged commit d1befdd into NixOS:release-20.09 Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liff @worldofpeace @risicle