Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-appservice-irc: init at 0.20.3 #98136

Closed
wants to merge 1 commit into from
Closed

matrix-appservice-irc: init at 0.20.3 #98136

wants to merge 1 commit into from

Conversation

gdamjan
Copy link
Contributor

@gdamjan gdamjan commented Sep 16, 2020

Motivation for this change

This is a new package the matrix-appservice-irc which is the irc gateway used with matrix. The package is based on the existing .matrix-appservice-discord, and the rest is generated by node2nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested on an just started container with nix:

$ podman run -ti --rm  -v ~/src/nixpkgs:/nixpkgs nixos/nix:latest
# NIX_PATH=nixpkgs=/nixpkgs nix-build '<nixpkgs>' -A matrix-appservice-irc

@ajs124
Copy link
Member

ajs124 commented Sep 16, 2020 •
edited

Attempt number 8 (#95854) it is 🤣

@gdamjan
Copy link
Contributor Author

gdamjan commented Sep 17, 2020

oh lol, should've checked first :)

@gdamjan gdamjan closed this Sep 17, 2020
@gdamjan gdamjan deleted the add-matrix-appservice-irc branch October 29, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gdamjan @ajs124