Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML: Add test for <input type=tel> matching :dir() #25599

Merged
merged 2 commits into from Sep 22, 2020
Merged

HTML: Add test for <input type=tel> matching :dir() #25599

merged 2 commits into from Sep 22, 2020

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Sep 17, 2020

Part of testing plan #25569

@zcorpan zcorpan mentioned this pull request Sep 17, 2020
Open
26 tasks
@zcorpan
Copy link
Member Author

zcorpan commented Sep 17, 2020

Firefox now fails this test. It doesn't seem to implement this part of the spec:

If the element is an input element whose type attribute is in the Telephone state, and the dir attribute is not in a defined state (i.e. it is not present or has an invalid value)

The directionality of the element is 'ltr'.

https://html.spec.whatwg.org/multipage/dom.html#the-directionality

@zcorpan
Copy link
Member Author

zcorpan commented Sep 17, 2020 •
edited

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1665655

domenic
domenic approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@domenic domenic left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, seems to match the spec, and sets us up for better testing in the future by splitting lines. Nice!

@zcorpan zcorpan requested a review from emilio September 18, 2020 11:24
@zcorpan
Copy link
Member Author

zcorpan commented Sep 18, 2020

Thanks @domenic! I'd like to see a +1 from @emilio before landing this. 🙂

emilio
emilio approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this as it matches the spec as of right now. If we want to change the spec then this test should be tweaked too of course... I'm personally not a fan of the <input type=tel> special-case here, but that's no reason to object :)

@zcorpan
Copy link
Member Author

zcorpan commented Sep 22, 2020

Thanks! File a spec issue if you think the spec should change. 🙂

@zcorpan zcorpan merged commit aaf496b into master Sep 22, 2020
@zcorpan zcorpan deleted the bocoup/dir-pseudo-input-type-tel branch September 22, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

@emilio emilio emilio approved these changes

@annevk annevk Awaiting requested review from annevk

@foolip foolip Awaiting requested review from foolip

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@lilles lilles Awaiting requested review from lilles

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@domenic domenic

Labels
html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zcorpan @domenic @emilio @wpt-pr-bot