Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zettlr #98123

Closed
wants to merge 1 commit into from
Closed

Add Zettlr #98123

wants to merge 1 commit into from

Conversation

beardhatcode
Copy link
Contributor

@beardhatcode beardhatcode commented Sep 16, 2020

Motivation for this change

I wanted to use my favourite markdown editor.

Questions

Use some fonts are missing when exporting to PDF at the moment.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip" (new package, no packages depend)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@beardhatcode
Copy link
Contributor Author

@beardhatcode
Copy link
Contributor Author

beardhatcode commented Sep 17, 2020

@tfmoraes, could you take a quick look at this PR?
Do you think we could add the pandoc and latex stuff to your zettlr.nix ?

I don't know if it is easy to also substitute the electron in the appimage with the nix electron. Do you ave any insights on that?

@tfmoraes
Copy link
Contributor

Hi @beardhatcode. I've created a branch to try to package Zettlr directly from source code using yarn2nix. See it here https://github.com/tfmoraes/nixpkgs/tree/zettlr-1.7.5_yarn . It's launching Zettlr but the GUI doesn't seem correct.

@beardhatcode
Copy link
Contributor Author

i took a look at it. The reason I used the deb rather than the repo was because the deb is the result of yarn run release:linux. This step creates a asar file which basically contains all the JavaScript except electron (and pandoc), so that is convenient.

I took a look at your code, and it might be because you are using electron instead of electron_9. I can't try it myself atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants