Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corefonts: fix hash mismatch update #98122

Merged
merged 1 commit into from Sep 19, 2020
Merged

corefonts: fix hash mismatch update #98122

merged 1 commit into from Sep 19, 2020

Conversation

turboMaCk
Copy link
Member

@turboMaCk turboMaCk commented Sep 16, 2020 •
edited

This fixes error:

fix hash missmatch
wanted: sha256:0baadsrgpqj15fgjmcn0aim0k0nk7mvivcxinw1zwg61kkcwhalx
got:    sha256:089d2m9bvaacj36qdq77pcazji0sbbr796shic3k52cpxkjnzbwh
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

danieldk
danieldk approved these changes Sep 19, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Result of nixpkgs-review pr 98122 1

1 package built:
  • corefonts

I wondered what changed the fixed-output. Turns out it was 6dd3b54.

@danieldk danieldk merged commit a9953f1 into NixOS:master Sep 19, 2020
@turboMaCk
Copy link
Member Author

btw @danieidk I'm not entirely sure but I think this might need to be backported to release. But I'm not completely sure about that.

@danieldk
Copy link
Contributor

btw @danieidk I'm not entirely sure but I think this might need to be backported to release. But I'm not completely sure about that.

Since it this is a fixed-output derivation and the Nix binary cache has never been garbage collected, this should continue to work. Though I think it's worth backporting, it's a bug and the backport is unlikely to break anything.

@Ma27
Copy link
Member

Ma27 commented Oct 1, 2020

@turboMaCk @danieldk I just got bitten by this. In fact, this isn't built on Hydra since it's an unfree tarball. Will port this at least to 20.09 and - if needed - to 20.03 as well.

@Ma27
Copy link
Member

Ma27 commented Oct 1, 2020

On 20.03 I don't need to change anything, I'm able to build /nix/store/w0q9i95sy1hzcx4z40i0f4mnan3l6vaa-corefonts-1 on b4db68f.

Pushed to release-20.09 as 510a2d9. Thanks for taking care of that!

@Ma27 Ma27 added the 8.has: port to stable A PR already has a backport to the stable release. label Oct 1, 2020
@danieldk
Copy link
Contributor

danieldk commented Oct 1, 2020

Forgot that corefonts is non-free. Thanks for the backport!

@turboMaCk turboMaCk deleted the corefonts-output-hash branch February 2, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@turboMaCk @danieldk @Ma27