Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pandas: 1.1.1 -> 1.1.4 & cleanup #98162

Closed
wants to merge 3 commits into from
Closed

pythonPackages.pandas: 1.1.1 -> 1.1.4 & cleanup #98162

wants to merge 3 commits into from

Conversation

drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Sep 17, 2020 •
edited

Motivation for this change

https://github.com/pandas-dev/pandas/releases/tag/v1.1.4

Mostly bugfix & regression fixes.

While upgrading, I saw a few things in the nix file that could use some cleanup:

  • Add changelog
  • sort dependencies
  • Convert tests to more-standard pytestCheckHook
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Didn't do nix-review because of large rebuild

@ofborg ofborg bot requested review from 7c6f434c and knedlsepp September 17, 2020 15:25
@drewrisinger
pythonPackages.pandas: cleanup
20220dd 
* Sort imports
* add changelog
@drewrisinger
pythonPackages.pandas: 1.1.1 -> 1.1.4
bf848a7 
This is a minor bug-fix release in the 1.1.x series and includes some regression fixes
and bug fixes.

https://github.com/pandas-dev/pandas/releases/tag/v1.1.4
@drewrisinger
pythonPackages.pandas: convert to pytestCheckHook
0e08416
@drewrisinger drewrisinger changed the title pythonPackages.pandas: 1.1.1 -> 1.1.2 & cleanup pythonPackages.pandas: 1.1.1 -> 1.1.4 & cleanup Nov 4, 2020
@drewrisinger
Copy link
Contributor Author

ping @FRidh & maintainer @knedlsepp
I know this is outside the standard python package update script, but I thought the cleanup & other updates were worth the PR.

knedlsepp
knedlsepp approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@knedlsepp knedlsepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good IMHO.
We could pin the changelog to the particular version. Not sure what's generally the best idea.

pkgs/development/python-modules/pandas/default.nix
# https://github.com/pandas-dev/pandas/issues/14866
# pandas devs are no longer testing i686 so safer to assume it's broken
broken = stdenv.isi686;
homepage = "https://pandas.pydata.org/";
changelog = "https://pandas.pydata.org/docs/whatsnew/index.html";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't even aware we track these. Just read up in the manual that it "may use expansion to refer to the correct changelog". So we could use:" https://pandas.pydata.org/docs/whatsnew/v${version}.html" here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, my preference order of operations when adding changelogs to existing packages has been:

  1. Generic user-facing changelog (less likely to break), e.g. on readthedocs/whichever site
  2. Version-specific link, user-facing
  3. GitHub release, populated with version number
  4. Some other changelog if I can find it.

Hence I chose 1 here.

@FRidh
Copy link
Member

FRidh commented Nov 5, 2020

Thank you. I've pushed the commits to #101636.

@FRidh FRidh closed this Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knedlsepp knedlsepp knedlsepp approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drewrisinger @FRidh @knedlsepp