pythonPackages.netaddr: 0.7.19 -> 0.8.0 #98151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: python
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
drewrisinger
suggested changes
Sep 17, 2020
| }) | ||
| ]; | ||
| checkInputs = [ glibcLocales pytest ] | ||
| ++ stdenv.lib.optionals (pythonOlder "3.7") [ importlib-resources ] ; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| homepage = "https://github.com/drkjam/netaddr/"; |
There was a problem hiding this comment.
Suggested change
| homepage = "https://github.com/drkjam/netaddr/"; | |
| homepage = "https://netaddr.readthedocs.io/en/latest/"; | |
| changelog = "https://netaddr.readthedocs.io/en/latest/changes.html"; |
That github repo is out of date.
Would you consider adding yourself as maintainer as well, since this package doesn't have a maintainer?
There was a problem hiding this comment.
I updated the homepage to point to the netaddr/netaddr GitHub repo, which seems to be the new home.
I'd prefer not to add myself as a maintainer. I don't know much about this package other than it's in my nix-darwin system closure and doesn't build on current macOS without an update.
There was a problem hiding this comment.
I generally prefer to point the homepage to what would make the most sense for users, not maintainers (i.e. documentation, not the repository), under the assumption that maintainers can find the repository themselves (though to be fair that's mostly for packages using fetchFromGitHub, so the GitHub is obvious).
The nixpkgs manual also hints at this, by showing the GNU manual in homepage. There's a not-used-enough meta.downloadPage attribute that the GitHub link would best fit in:
downloadPage = "https://github.com/netaddr/netaddr/releases";
There was a problem hiding this comment.
I generally prefer to point the homepage to what would make the most sense for users, not maintainers
Seems reasonable to me, I wasn’t aware of this convention but I do see a number of usages in the python part of nixpkgs. Updated to have the recommended homepage and downloadPage
thefloweringash
force-pushed
the
netaddr-update
branch
from
86da772
to
237c76d
Compare
|
Result of 4 packages marked as broken and skipped:
6 packages failed to build:
79 packages built:
|
Updating to >= 0.7.20 fixes tests on macOS Catalina and newer:
# inet_pton has to be different on Mac OSX *sigh*
assert IPAddress('010.000.000.001', flags=INET_PTON) == IPAddress('10.0.0.1')
> assert int_to_str(0xffff) == '::0.0.255.255'
E AssertionError: assert '::ffff' == '::0.0.255.255'
E - ::0.0.255.255
E + ::ffff
thefloweringash
force-pushed
the
netaddr-update
branch
from
237c76d
to
b1c7cd4
Compare
drewrisinger
approved these changes
Sep 20, 2020
jonringer
approved these changes
Sep 20, 2020
There was a problem hiding this comment.
LGTM
failures are broken on target branch
https://github.com/NixOS/nixpkgs/pull/98151
5 packages marked as broken and skipped:
linuxPackages_hardkernel_4_14.bcc linuxPackages_hardkernel_4_14.bpftrace linuxPackages_hardkernel_latest.bcc linuxPackages_hardkernel_latest.bpftrace python27Packages.junos-eznc
3 packages failed to build:
python37Packages.WSME python38Packages.WSME terraform-compliance
81 packages built:
ansible ansible-lint ansible_2_8 ansible_2_9 dnsrecon kargo linuxPackages-libre.bcc linuxPackages-libre.bpftrace linuxPackages-libre.oci-seccomp-bpf-hook linuxPackages.bcc linuxPackages.bpftrace linuxPackages.oci-seccomp-bpf-hook linuxPackages_4_14.bcc linuxPackages_4_14.bpftrace linuxPackages_4_19.bcc linuxPackages_4_19.bpftrace linuxPackages_4_4.bcc linuxPackages_4_4.bpftrace linuxPackages_4_9.bcc linuxPackages_4_9.bpftrace linuxPackages_5_7.bcc linuxPackages_5_7.bpftrace linuxPackages_5_7.oci-seccomp-bpf-hook linuxPackages_5_8.bcc linuxPackages_5_8.bpftrace linuxPackages_5_8.oci-seccomp-bpf-hook linuxPackages_hardened.bcc linuxPackages_hardened.bpftrace linuxPackages_hardened.oci-seccomp-bpf-hook linuxPackages_latest-libre.bcc linuxPackages_latest-libre.bpftrace linuxPackages_latest-libre.oci-seccomp-bpf-hook linuxPackages_latest_hardened.bcc linuxPackages_latest_hardened.bpftrace linuxPackages_latest_hardened.oci-seccomp-bpf-hook linuxPackages_latest_xen_dom0.bcc linuxPackages_latest_xen_dom0.bpftrace linuxPackages_latest_xen_dom0.oci-seccomp-bpf-hook linuxPackages_latest_xen_dom0_hardened.bcc linuxPackages_latest_xen_dom0_hardened.bpftrace linuxPackages_latest_xen_dom0_hardened.oci-seccomp-bpf-hook linuxPackages_testing_bcachefs.bcc linuxPackages_testing_bcachefs.bpftrace linuxPackages_testing_bcachefs.oci-seccomp-bpf-hook linuxPackages_xen_dom0.bcc linuxPackages_xen_dom0.bpftrace linuxPackages_xen_dom0.oci-seccomp-bpf-hook linuxPackages_xen_dom0_hardened.bcc linuxPackages_xen_dom0_hardened.bpftrace linuxPackages_xen_dom0_hardened.oci-seccomp-bpf-hook linuxPackages_zen.bcc linuxPackages_zen.bpftrace linuxPackages_zen.oci-seccomp-bpf-hook matrix-synapse octoprint python27Packages.ansible python27Packages.netaddr python27Packages.pyrad python27Packages.pytest-ansible python27Packages.wfuzz python37Packages.ansible python37Packages.ansible-kernel python37Packages.ansible-lint python37Packages.ansible-runner python37Packages.django-postgresql-netfields python37Packages.junos-eznc python37Packages.netaddr python37Packages.privacyidea python37Packages.pyrad python37Packages.pytest-ansible python37Packages.wfuzz python38Packages.ansible-kernel python38Packages.ansible-runner python38Packages.django-postgresql-netfields python38Packages.junos-eznc python38Packages.netaddr python38Packages.privacyidea python38Packages.pyrad python38Packages.pytest-ansible wfuzz theharvester
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to >= 0.7.20 fixes tests on macOS Catalina and newer:
Motivation for this change
Package update and fixing tests on newer macOS versions.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)