Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.zarith: 1.9 -> 1.10 #98164

Merged
merged 1 commit into from Sep 21, 2020
Merged

ocamlPackages.zarith: 1.9 -> 1.10 #98164

merged 1 commit into from Sep 21, 2020

Conversation

Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Sep 17, 2020 •
edited

Motivation for this change

New version, fixes some serious bugs of the previous one.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Zimmi48 Zimmi48 mentioned this pull request Sep 17, 2020
Merged
@Zimmi48
Copy link
Member Author

Zimmi48 commented Sep 17, 2020

Running nix-review gives:

2 packages failed to build:
ocamlPackages.irmin-unix ocamlPackages.nocrypto

38 packages built:
alt-ergo dune-release framac fstar google-drive-ocamlfuse jackline libbap ocamlPackages.asn1-combinators
ocamlPackages.cohttp-lwt-unix ocamlPackages.conduit-lwt-unix ocamlPackages.cryptokit ocamlPackages.curly 
ocamlPackages.eliom ocamlPackages.fiat-p256 ocamlPackages.gapi_ocaml ocamlPackages.git ocamlPackages.git-http 
ocamlPackages.git-unix ocamlPackages.graphql-cohttp ocamlPackages.irmin-git ocamlPackages.irmin-graphql 
ocamlPackages.irmin-http ocamlPackages.jwto ocamlPackages.mirage-crypto-pk ocamlPackages.ocsigen-start 
ocamlPackages.ocsigen-toolkit ocamlPackages.ocsigen_server ocamlPackages.opium ocamlPackages.otr 
ocamlPackages.prof_spacetime ocamlPackages.tls ocamlPackages.x509 ocamlPackages.zarith opa python27Packages.bap 
python37Packages.bap python38Packages.bap why3

@ejgallego
Copy link

Where can one see the logs Théo?

@Zimmi48
Copy link
Member Author

Zimmi48 commented Sep 18, 2020

Note sure if this was some transient error, but when trying to build those packages manually, I didn't get any failure.

@ejgallego
Copy link

Ok thanks!

@Zimmi48 Zimmi48 requested a review from vbgl September 18, 2020 12:09
@vbgl
Copy link
Contributor

vbgl commented Sep 21, 2020

@GrahamcOfBorg build alt-ergo framac fstar jackline

@vbgl vbgl merged commit 0bbeca2 into NixOS:master Sep 21, 2020
@vbgl
Copy link
Contributor

vbgl commented Sep 21, 2020

Merged into 20.09 as 4c1ae47

@Zimmi48 Zimmi48 deleted the zarith-1.10 branch September 21, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl Awaiting requested review from vbgl

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zimmi48 @ejgallego @vbgl