Treat NG objects inside legacy fragmentation as monolithic. #25598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 17, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2416069
branch
2 times, most recently
from
b2ff607
to
69f7d0e
Compare
And vice versa: Treat legacy objects as monolithic inside NG block fragmentation. The two block fragmentation implementations (NG and legacy) cannot cooperate, so once we switch engine somewhere inside a fragmentation context, we need to treat that subtree as monolithic. This requires us to specify which fragmentation engine is being in use when calling GetPaginationBreakability(), at least when possible at all. This required some work in LayoutFlowThread and LayoutMultiColumnFlowThread. Bug: 1127112 Change-Id: I8e0c4d17fd8985c488614e01db23a0c63e899679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416069 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#808334}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2416069
branch
from
69f7d0e
to
1cf430c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And vice versa: Treat legacy objects as monolithic inside NG block
fragmentation.
The two block fragmentation implementations (NG and legacy) cannot
cooperate, so once we switch engine somewhere inside a fragmentation
context, we need to treat that subtree as monolithic.
This requires us to specify which fragmentation engine is being in use
when calling GetPaginationBreakability(), at least when possible at all.
This required some work in LayoutFlowThread and
LayoutMultiColumnFlowThread.
Bug: 1127112
Change-Id: I8e0c4d17fd8985c488614e01db23a0c63e899679
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416069
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#808334}