Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requests-aws4auth: unbreak on python 3.x, cleanup #98138

Closed
wants to merge 1 commit into from
Closed

requests-aws4auth: unbreak on python 3.x, cleanup #98138

wants to merge 1 commit into from

Conversation

amaxine
Copy link
Member

@amaxine amaxine commented Sep 17, 2020 •
edited

Motivation for this change

Entirely removed postPatch as that file no longer exists. Discovered this breakage when attempting to run the ELK test - post changes the test appears to finish fine, including elasticsearch-curator.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@amaxine
requests-aws4auth: unbreak on python 3.x, cleanup
b620f88 
postPatch was attemptting to sed in a file that no longer exists
tests are still broken on python 3.x

additionally misc cleanup and corrected homepage to be current
@amaxine
Copy link
Member Author

amaxine commented Sep 17, 2020

Result of nixpkgs-review pr 98138 1

4 packages built:
  • elasticsearch-curator
  • python27Packages.requests-aws4auth
  • python37Packages.requests-aws4auth
  • python38Packages.requests-aws4auth

@ofborg ofborg bot requested a review from basvandijk September 17, 2020 00:48
FRidh
FRidh requested changes Sep 17, 2020
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't make any unnecessary style changes.

@jonringer
Copy link
Contributor

I think I merged a fix for this, sorry, I saw the other first

@amaxine amaxine closed this Sep 18, 2020
@amaxine amaxine deleted the maxine/unbreak_requests-aws4auth branch September 18, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

@jonringer jonringer Awaiting requested review from jonringer

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amaxine @jonringer @FRidh