Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noto-fonts-emoji: unstable-2020-08-20 → 2020-09-16 #98159

Merged
merged 2 commits into from Sep 20, 2020
Merged

noto-fonts-emoji: unstable-2020-08-20 → 2020-09-16 #98159

merged 2 commits into from Sep 20, 2020

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Sep 17, 2020 •
edited

Motivation for this change

Unicode 13.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann sternenseemann force-pushed the noto-emoji-unicode-13.1 branch 2 times, most recently from ba9902f to be041ab Compare September 17, 2020 14:10
@ofborg ofborg bot requested a review from Mathnerd314 September 17, 2020 14:26
Mathnerd314
Mathnerd314 suggested changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@Mathnerd314 Mathnerd314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They bumped the required version of nototools / notofonttools to 0.2.13:
googlefonts/noto-emoji@c9fde67

Currently we have 0.2.12, so you should update that too.

@sternenseemann
Copy link
Member Author

@GrahamcOfBorg build python3Packages.nototools

Mathnerd314
Mathnerd314 approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@Mathnerd314 Mathnerd314 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. I didn't actually test the emoji rendering but it's just a version bump so I doubt anything broke.

@sternenseemann
Copy link
Member Author

Builds fine for me, resulting font seems good (did a sanity check with harfbuzz).

danieldk
danieldk approved these changes Sep 20, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 98159 1

4 packages built:
  • noto-fonts-emoji
  • python37Packages.nototools
  • python38Packages.nototools
  • twitter-color-emoji

@danieldk danieldk merged commit b83824d into NixOS:master Sep 20, 2020
@sternenseemann sternenseemann deleted the noto-emoji-unicode-13.1 branch September 20, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@Mathnerd314 Mathnerd314 Mathnerd314 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sternenseemann @danieldk @Mathnerd314