Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-native-debugger: 0.9.10 -> 0.11.4 #98129

Merged
merged 3 commits into from Sep 17, 2020
Merged

react-native-debugger: 0.9.10 -> 0.11.4 #98129

merged 3 commits into from Sep 17, 2020

Conversation

demyanrogozhin
Copy link
Member

@demyanrogozhin demyanrogozhin commented Sep 16, 2020 •
edited

Motivation for this change

Small fix for generated desktop file.

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Sep 17, 2020

@demyanrogozhin while you're at it, could you also fix the error thrown at startup?

(React Native Debugger:8639): Pango-ERROR **: 10:13:19.324: Harfbuzz version too old (1.4.2)

[1]    8639 trace trap (core dumped)  ./result/bin/React\ Native\ Debugger

@demyanrogozhin
Copy link
Member Author

while you're at it, could you also fix the error thrown at startup?
@Ma27 Fixed by upgrading to latest version.

@demyanrogozhin demyanrogozhin changed the title react-native-debugger: fix build react-native-debugger: 0.9.10 -> 0.11.4 Sep 17, 2020
@Ma27 Ma27 merged commit 85ca7f7 into NixOS:master Sep 17, 2020
@Ma27
Copy link
Member

Ma27 commented Sep 17, 2020

Thanks! Ported to stable as def9780, df4c3f4, e20e342.

@Ma27 Ma27 added the 8.has: port to stable A PR already has a backport to the stable release. label Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@demyanrogozhin @Ma27