Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chez: add env hook #98128

Merged
merged 1 commit into from Sep 23, 2020
Merged

chez: add env hook #98128

merged 1 commit into from Sep 23, 2020

Conversation

meithecatte
Copy link
Contributor

@meithecatte meithecatte commented Sep 16, 2020 •
edited

Motivation for this change

As a follow-up to #97927, chez can now find its libraries in a
nix-shell, and derivations for such libraries don't need to handle the
search path themselves.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • scheme has been tested interactively, try echo '(import (srfi :1))' | nix-shell -I nixpkgs=$(pwd) -p chez chez-srfi --run scheme
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@meithecatte
chez: add env hook
8f60607 
As a follow-up to NixOS#97927, chez can now find its libraries in a
nix-shell, and derivations for such libraries don't need to handle the
search path themselves.
@ofborg ofborg bot requested a review from thoughtpolice September 16, 2020 21:24
@meithecatte meithecatte mentioned this pull request Sep 21, 2020
Merged
10 tasks
@thoughtpolice thoughtpolice merged commit 02be5a8 into NixOS:master Sep 23, 2020
@thoughtpolice
Copy link
Member

Thanks!

@meithecatte meithecatte mentioned this pull request Sep 23, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@meithecatte @thoughtpolice