Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sky: drop #98125

Merged
merged 1 commit into from Sep 18, 2020
Merged

sky: drop #98125

merged 1 commit into from Sep 18, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Sep 16, 2020

Motivation for this change

download 404s and maintainer doesn't use the program anymore.

cc @Scriptkiddi

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Scriptkiddi Scriptkiddi self-requested a review September 18, 2020 08:04
@ajs124 ajs124 merged commit 61d7582 into NixOS:master Sep 18, 2020
@ajs124 ajs124 deleted the drop/sky branch September 18, 2020 13:09
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/sky-skype-for-business-broken/9651/2

@das-g das-g mentioned this pull request Jun 4, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants