Don't allow legacy list item markers inside an NG subtree. #25574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 16, 2020
We usually don't encounter NG objects inside a legacy layout subtree, but this may happen when we have display types that aren't implemented in the legacy engine, e.g. MathML and custom layout. This situation should be rare enough, and the combination of list items and MathML / custom layout doesn't seem like a very common use case. So just don't go there, and instead keep looking for a better candidate to place the list item marker inside. Bug: 1127112 Change-Id: I74c39fae7e5c48d73d5603efca486a05c234a25a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414268 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#807788}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2414268
branch
from
e9b8202
to
27ec1d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We usually don't encounter NG objects inside a legacy layout subtree,
but this may happen when we have display types that aren't implemented
in the legacy engine, e.g. MathML and custom layout.
This situation should be rare enough, and the combination of list items
and MathML / custom layout doesn't seem like a very common use case. So
just don't go there, and instead keep looking for a better candidate to
place the list item marker inside.
Bug: 1127112
Change-Id: I74c39fae7e5c48d73d5603efca486a05c234a25a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414268
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807788}