Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix html/coep/cross-origin-isolated-permission.https.html #25584

Merged
merged 4 commits into from Sep 24, 2020

Conversation

yutakahirano
Copy link
Contributor

  • Add an intermediary frame to actually test Permissions-Policy.
  • Unquote self.
  • Use () instead of "none".

Fixes whatwg/html#5888.

 - Add an intermediary frame to actually test Permissions-Policy.
 - Unquote `self`.
 - Use `()` instead of `"none"`.

Fixes whatwg/html#5888.
@yutakahirano
Copy link
Contributor Author

@clelland @annevk can you take a look?

Copy link
Member

@mikewest mikewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-25584 September 17, 2020 06:09 Inactive
@yutakahirano
Copy link
Contributor Author

@clelland @annevk are you fine with this change? I'll merge this tomorrow if there are no further comments.

@yutakahirano yutakahirano merged commit 450ac78 into master Sep 24, 2020
@yutakahirano yutakahirano deleted the yhirano/cross-origin-isolated-wpt-fix branch September 24, 2020 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cross-origin-isolated permission tests
5 participants