redesign: Add events banner (with NixCon banner) #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And make the "first child" banner stick to the top
|
Looks OK. Maybe make a short sentence out of it. "is online" sounds like some content release. better use something like "takes place online" the countdown will probably use JS and you probably can find some code on stackoverflow that is fine for now. but what about people that don't have JS enabled? having the day at least update daily would be nice |
…ure/2020-r/frontpage-banner
|
cc @anamarijas for design review: https://5f6371fc4f81460f301e5f8c--nixos-homepage.netlify.app |
|
@domenkozar better to use #506 for the review. |
|
Thank you @garbas for taking the time to improve what I literally threw together in the quickest manner as a last task :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not positive on the wording, but the long sentence didn't feel right.
Compare to mockups:
Implementing the numbers on top of days for only days would be quite cumbersome. Furthermore, it's not like it's really important to have a second-by-second countdown for now.
I don't think it would be too time consuming to also add more than days, and to make it update, but I'm not really sure it's worth it for the time being.
Let's see your thoughts all and see how this evolves?