Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.gsconnect: 39 -> 41 #98152

Merged
merged 1 commit into from Sep 17, 2020
Merged

gnomeExtensions.gsconnect: 39 -> 41 #98152

merged 1 commit into from Sep 17, 2020

Conversation

doronbehar
Copy link
Contributor

Update patch so it'll apply on v41.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar
gnomeExtensions.gsconnect: 39 -> 41
3f1a356 
Update patch so it'll apply on v41.
@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Sep 17, 2020
@ofborg ofborg bot requested a review from etu September 17, 2020 09:00
@doronbehar doronbehar merged commit 1ae3671 into NixOS:master Sep 17, 2020
@doronbehar doronbehar deleted the pkg/gnomeExtensions/gsconnect branch September 17, 2020 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@etu etu Awaiting requested review from etu

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doronbehar @bjornfor