Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] dmidecode version bump to 3.2.8 #98175

Closed
wants to merge 2 commits into from
Closed

[20.03] dmidecode version bump to 3.2.8 #98175

wants to merge 2 commits into from

Conversation

superherointj
Copy link
Contributor

(cherry picked from commit 0cd61da)

Motivation for this change

PR#97614 was missing dmidecode's version bump.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@superherointj
dmidecode version bump to 3.2.8
b958721 
(cherry picked from commit 0cd61da)
@superherointj superherointj changed the title dmidecode version bump to 3.2.8 [20.03] dmidecode version bump to 3.2.8 Sep 17, 2020
blitz
blitz suggested changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@blitz blitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is broken, because it tries to fetch dmidecode-3.2.8.tar.xz from the savannah mirrors, which does not exist. See http://ftp.twaren.net/Unix/NonGNU/dmidecode/

blitz referenced this pull request Sep 17, 2020
@superherointj
dmidecode version bump to 3.2.8
0cd61da
@samueldr samueldr marked this pull request as draft September 17, 2020 19:22
@samueldr
Copy link
Member

Converted to draft until #98171 is ready.

@superherointj superherointj deleted the release-20.03 branch September 17, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blitz blitz blitz requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@superherointj @samueldr @blitz