dmidecode version bump to 3.2.8 #98171
Conversation
|
Shouldn't this be setting |
There was a problem hiding this comment.
Quoting @blitz
This is broken, because it tries to fetch dmidecode-3.2.8.tar.xz from the savannah mirrors, which does not exist. See http://ftp.twaren.net/Unix/NonGNU/dmidecode/
|
Additionally, this is not truly "3.2.8", upstream still refers to it as 3.2... We don't have a way to differentiate between versions of unversioned patched-up software defined and/or documented. Nothing similar to what I believe debian does, adding "+n" where n is the amount of debian-specific updates the package had. This is causing only an issue with |
Yes, it looks like there is a 3.2.8 release when there really isn't.
Fedora seems to call it |
|
Which sort of version to use then "3.2-8" or "3.2.8"? Arch did "3.2-2" (major_version.minor_version-release_number). |
Co-authored-by: Julian Stecklina <js@alien8.de>
|
As I have seen here, there is no need for version bumping. Version bumping is just a convention, and in Nixpkgs those things have way less importance compared with other distros. They aren't used by anything serious as an internal algorithm for self-updating. (Even because the ryantm bot does this for us :P ) By updating the expression with the required patches, the build bots will update the package automatically (after a couple of days I suppose). Further, the most recent version on Repology is 3.2 anyway. There is no motivation to edit version string here. On the other hand, I suggest creating a new expression, something like "dmidecode/unstable.nix" fetching the last Git sources. But it can wait... |
Motivation for this change
PR#97614 was missing dmidecode's version bump.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)