Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hime: init at unstable-2020-06-27 #98163

Merged
merged 2 commits into from Oct 4, 2020
Merged

hime: init at unstable-2020-06-27 #98163

merged 2 commits into from Oct 4, 2020

Conversation

yanganto
Copy link
Member

Motivation for this change

Add hime input method

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
    Result: No diff detected, stopping review...
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ref: HIME team build script on Arch
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=hime-git

@yanganto yanganto changed the title hime: init hime: init at 2020-06-27 Sep 24, 2020
@yanganto yanganto changed the title hime: init at 2020-06-27 hime: init at unstable-2020-06-27 Sep 24, 2020
@yanganto yanganto changed the title hime: init at unstable-2020-06-27 [WIP] hime: init at unstable-2020-06-27 Sep 24, 2020
@yanganto yanganto changed the title [WIP] hime: init at unstable-2020-06-27 hime: init at unstable-2020-06-27 Oct 3, 2020
@yanganto
Copy link
Member Author

yanganto commented Oct 4, 2020

Hi @marsam, @worldofpeace,
Could you take a look at this PR? I am a new user of NixOS and want to use the input method which I used in Archlinux.
Many thanks.

@marsam marsam merged commit e940c41 into NixOS:master Oct 4, 2020
@yanganto yanganto mentioned this pull request Oct 16, 2020
Merged
10 tasks
@yanganto yanganto deleted the hime branch May 29, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlvzk mlvzk mlvzk left review comments

@marsam marsam marsam approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yanganto @marsam @mlvzk