Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3.pkgs.libiio: fix build #98149

Merged
merged 1 commit into from Sep 17, 2020
Merged

python3.pkgs.libiio: fix build #98149

merged 1 commit into from Sep 17, 2020

Conversation

povik
Copy link
Contributor

@povik povik commented Sep 17, 2020 •
edited

Add missing setuptools dependency.

ZHF: #97479

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@povik
python3.pkgs.libiio: fix build
ce0a59c 
Add missing setuptools dependency.
@ofborg ofborg bot requested a review from thoughtpolice September 17, 2020 07:40
@povik
Copy link
Contributor Author

povik commented Sep 17, 2020

nixpkgs-review pr 98149 raised no errors.

@risicle
Copy link
Contributor

risicle commented Sep 17, 2020

WFM linux x86_64.

@risicle risicle merged commit 5df26fe into NixOS:master Sep 17, 2020
@povik povik mentioned this pull request Sep 18, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@povik @risicle @Janik-Haag