Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jetbrains products #98165

Closed
wants to merge 9 commits into from
Closed

Update jetbrains products #98165

wants to merge 9 commits into from

Conversation

Gerschtli
Copy link
Contributor

Motivation for this change

Run the update.pl script after manual fixing the src url for MPS.

Tested only jetbrains.idea-ultimate which worked.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Sep 18, 2020

Would you mind commiting your update.pl-fix here as well? :)

@Ma27 Ma27 self-requested a review September 18, 2020 15:46
@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 18, 2020
@Gerschtli
Copy link
Contributor Author

Unfortunately this was a manual change in the default.nix file. I will work on an improved update script, when I have more time :)

@liff
Copy link
Contributor

liff commented Sep 21, 2020

This looks to be a duplicate of #98194, which was merged.

@Gerschtli
Copy link
Contributor Author

Yes, you are right. Closing this one.

@Gerschtli Gerschtli closed this Sep 21, 2020
@Gerschtli Gerschtli deleted the update/jetbrains branch September 21, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

@rasendubi rasendubi Awaiting requested review from rasendubi

@Mic92 Mic92 Awaiting requested review from Mic92

@loskutov loskutov Awaiting requested review from loskutov

@baldo baldo Awaiting requested review from baldo

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gerschtli @Ma27 @liff