Fieldset NG: Fix hit-testing for the rendered LEGEND, take 2 #25580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 17, 2020
crrev.com/806924 missed to add |accumulated_offset| to the LEGEND's offset. So hit-testing didn't work well if the FIELDSET was placed far from the origin. Bug: 1127743 Change-Id: I16c80b8074f9082516a6ecd5bb82407bbe7d3551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413681 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#807797}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2413681
branch
from
1fa6406
to
7dcd69a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crrev.com/806924 missed to add |accumulated_offset| to the LEGEND's
offset. So hit-testing didn't work well if the FIELDSET was placed far
from the origin.
Bug: 1127743
Change-Id: I16c80b8074f9082516a6ecd5bb82407bbe7d3551
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413681
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807797}