Fix: demand PROXY protocol header for every UDP packet #12
+4
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And not, as by default, for every UDP stream. Upstream proxies can be configured to behave like this, where they create a new UDP stream for every UDP packet they receive. The current code made it possible for a user to send its own PROXY protocol header after the first packet, making it possible for us to start querying random IP/port combinations. The fix was either changing the upstream proxy (which we did) or make this code follow streams, add timeouts on the streams to forget about them, and make sure this is in sync with the upstream proxy. This is a very difficult task, as with UDP no state is transmitted from the upstream proxy to us (like with TCP). So the first option is a lot easier, a lot less code, and less likely to break.
TrueBrain
force-pushed
the
drop_mapping
branch
from
7ac8a26 to
b58e44a
Compare
…lopment The values are not relevant, as the local dynamodb will completely ignore it. But they do need to be set before the code actually works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And not, as by default, for every UDP stream.
Upstream proxies can be configured to behave like this, where
they create a new UDP stream for every UDP packet they receive.
The current code made it possible for a user to send its own
PROXY protocol header after the first packet, making it possible
for us to start querying random IP/port combinations. The fix was
either changing the upstream proxy (which we did) or make this code
follow streams, add timeouts on the streams to forget about them,
and make sure this is in sync with the upstream proxy. This is
a very difficult task, as with UDP no state is transmitted from
the upstream proxy to us (like with TCP). So the first option is
a lot easier, a lot less code, and less likely to break.