Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scream: 3.4 -> 3.6 #99414

Merged
merged 1 commit into from Apr 30, 2021
Merged

scream: 3.4 -> 3.6 #99414

merged 1 commit into from Apr 30, 2021

Conversation

arcnmx
Copy link
Member

@arcnmx arcnmx commented Oct 2, 2020

Motivation for this change

All receiver binaries have since been merged into one, so renamed from scream-receivers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Jan 18, 2021
View reviewed changes
pkgs/applications/audio/scream/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/scream/default.nix Outdated Show resolved Hide resolved
@arcnmx arcnmx force-pushed the scream branch 2 times, most recently from f7d2e75 to 63a378e Compare April 10, 2021 18:15
@arcnmx
Copy link
Member Author

arcnmx commented Apr 10, 2021

Rebased onto master and made the suggested changes, sorry that took so long.

SuperSandro2000
SuperSandro2000 reviewed Apr 11, 2021
View reviewed changes
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/scream/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/scream/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/scream/default.nix Show resolved Hide resolved
pkgs/applications/audio/scream/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

The suggestions from me are more commonly used and make it easier to know when something is enabled and not.

@arcnmx
scream: 3.4 -> 3.6
c219dfc 
Renamed from scream-receivers
@arcnmx
Copy link
Member Author

arcnmx commented Apr 30, 2021

@SuperSandro2000 ping?

@SuperSandro2000 SuperSandro2000 merged commit 1eb7187 into NixOS:master Apr 30, 2021
@arcnmx arcnmx deleted the scream branch April 30, 2021 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arcnmx @SuperSandro2000