Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catfs: init at unstable-2020-03-21 #99426

Merged
merged 1 commit into from Nov 24, 2020
Merged

catfs: init at unstable-2020-03-21 #99426

merged 1 commit into from Nov 24, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 2, 2020 •
edited

Motivation for this change

closes: #99315

some concerns about activity of upstream though: kahing/catfs#47 https://github.com/kahing/catfs/pulls

anyway did this as mostly an exercise for packing rust. Don't feel strongly if this gets added

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

I am not sure but should this be marked Unix only because fuse is not available on darwin?

@jonringer
Copy link
Contributor Author

darwin users should get a "not supported platform" error due to the fuse dependency

@jonringer
Copy link
Contributor Author

however, I already have it in os-specific/linux, so I may as well be coherent about it

@tomberek
Copy link
Contributor

Result of nixpkgs-review pr 99426 1

1 package built:
  • catfs

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 99426 run on x86_64-linux 1

1 package built:
  • catfs

@SuperSandro2000 SuperSandro2000 merged commit 77d45b8 into NixOS:master Nov 24, 2020
@jonringer jonringer deleted the add-catfs branch November 25, 2020 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

catfs
3 participants
@jonringer @SuperSandro2000 @tomberek